test: standardize on shorter healthcheck interval in docker-compose test config #4169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est config
For some testing (GitHub Actions test.yml is separate), we use test/docker-compose.yml
for test services. This standardizes on this healthcheck timing:
interval: 1s
timeout: 10s
retries: 30
The previous 'interval: 30s' for some services was unnecessarily slow.
It means the first healthcheck would always wait that long and one would
be waiting doing nothing. It is possibel with this change we will have a
very slow service not come up in time. If so, then we can increase the
retries or interval. Preceding values were willy-nilly.
david-luna
approved these changes
Jul 30, 2024
trentm
added a commit
that referenced
this pull request
Aug 1, 2024
…est config (#4169) For some testing (GitHub Actions test.yml is separate), we use test/docker-compose.yml for test services. This standardizes on this healthcheck timing: interval: 1s timeout: 10s retries: 30 The previous 'interval: 30s' for some services was unnecessarily slow. It means the first healthcheck would always wait that long and one would be waiting doing nothing. It is possibel with this change we will have a very slow service not come up in time. If so, then we can increase the retries or interval. Preceding values were willy-nilly.
fpm-peter
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
…est config (elastic#4169) For some testing (GitHub Actions test.yml is separate), we use test/docker-compose.yml for test services. This standardizes on this healthcheck timing: interval: 1s timeout: 10s retries: 30 The previous 'interval: 30s' for some services was unnecessarily slow. It means the first healthcheck would always wait that long and one would be waiting doing nothing. It is possibel with this change we will have a very slow service not come up in time. If so, then we can increase the retries or interval. Preceding values were willy-nilly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some testing (GitHub Actions test.yml is separate), we use test/docker-compose.yml
for test services. This standardizes on this healthcheck timing:
The previous 'interval: 30s' for some services was unnecessarily slow.
It means the first healthcheck would always wait that long and one would
be waiting doing nothing. It is possibel with this change we will have a
very slow service not come up in time. If so, then we can increase the
retries or interval. Preceding values were willy-nilly.