Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the npm publish step of the release process will use a "latest" dist-tag for a pre-release and should not #3615

Open
trentm opened this issue Sep 7, 2023 · 0 comments
Assignees
Labels
8.11-candidate agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Sep 7, 2023

I did a 4.0.0-rc.1 release recently. The resulting npm published package was dist-tagged with "latest":

% npm info elastic-apm-node dist-tags
{ latest: '4.0.0-rc.1', '2x': '2.17.3' }

The intent is that it does not mark a pre-release (a version with a hyphen in it) as "latest". I had played with https://www.npmjs.com/package/@trentm/npmplay and got the wrong impression that a bare npm publish would do the "right" thing (at least what I wanted). However, that isn't the case.

Proposal: have a "dev-utils/npm-publish.sh" that does the equivalent handling of dist-tagging that is done in "push-docker.sh" and "github-release.sh". As a bonus, we could possibly have it handle the "latest-" explicitly dist-tagging for non-latest-major maintenance branches, i.e. for the current "3.x" branch.

@trentm trentm self-assigned this Sep 7, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11-candidate agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

No branches or pull requests

1 participant