From bbed0fce335306bed2a1cd66424ed22329c27872 Mon Sep 17 00:00:00 2001 From: Enrico Joerns Date: Tue, 1 Mar 2022 20:53:44 +0100 Subject: [PATCH] src/utils: fix leaked groups and keys strings g_key_file_get_keys() and g_key_file_get_groups() both return newly-allocated arrays of strings. These need to be freed. Fixes coverity issues: | CID 1445509 (#2 of 2): Resource leak (RESOURCE_LEAK) | 4. leaked_storage: Variable rem_groups going out of scope leaks the storage it points to | CID 1445498 (#2 of 2): Resource leak (RESOURCE_LEAK) | 5. leaked_storage: Variable rem_keys going out of scope leaks the storage it points to. Signed-off-by: Enrico Joerns --- src/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utils.c b/src/utils.c index ee5d28a9e..154b1e5db 100644 --- a/src/utils.c +++ b/src/utils.c @@ -155,7 +155,7 @@ gchar *resolve_path(const gchar *basefile, gchar *path) gboolean check_remaining_groups(GKeyFile *key_file, GError **error) { gsize rem_num_groups; - gchar **rem_groups; + GStrv(rem_groups) = NULL; rem_groups = g_key_file_get_groups(key_file, &rem_num_groups); if (rem_num_groups != 0) { @@ -170,7 +170,7 @@ gboolean check_remaining_groups(GKeyFile *key_file, GError **error) gboolean check_remaining_keys(GKeyFile *key_file, const gchar *groupname, GError **error) { gsize rem_num_keys; - gchar **rem_keys; + GStrv(rem_keys) = NULL; rem_keys = g_key_file_get_keys(key_file, groupname, &rem_num_keys, NULL); if (rem_keys && rem_num_keys != 0) {