Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up running conformance tests #11

Open
wmdietl opened this issue Jul 10, 2024 · 1 comment
Open

Clean up running conformance tests #11

wmdietl opened this issue Jul 10, 2024 · 1 comment

Comments

@wmdietl
Copy link
Member

wmdietl commented Jul 10, 2024

#10 adds supports for running on conformance tests.

The fastest way was to duplicate the fields and have two @Test methods.
This seems a bit ugly, as the build.gradle file looks like two separate tests are run with different configurations.
But both tests are run with the same environment, just the different tests look at different parts.
Maybe this could be done more nicely, at least by removing the fields and setting this more cleanly.

Also note that deps isn't needed for samples, so clean that up, too.

@Haibo-S
Copy link
Contributor

Haibo-S commented Aug 29, 2024

I have made some changes in this pull request: #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants