Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add project documents #815

Merged
merged 7 commits into from
Oct 23, 2024
Merged

doc: add project documents #815

merged 7 commits into from
Oct 23, 2024

Conversation

sergey-melnychuk
Copy link
Collaborator

  • code coverage
  • architecture

@sergey-melnychuk sergey-melnychuk marked this pull request as ready for review October 23, 2024 12:30
@sergey-melnychuk sergey-melnychuk requested a review from a team October 23, 2024 12:30
@sergey-melnychuk sergey-melnychuk changed the title docs: add project documents doc: add project documents Oct 23, 2024
Copy link
Contributor

@ICavlek ICavlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially great work on the architecture document :) One small change that might be updated in the architecture.md, not all functions except starknet_call are proxied. starknet_getStorageAt also calls pathfinder_getProof and verifies it.

@sergey-melnychuk
Copy link
Collaborator Author

sergey-melnychuk commented Oct 23, 2024

Coverage Results:
|| Tested/Total Lines:
|| src/client.rs: 9/63
|| src/config.rs: 21/59
|| src/eth.rs: 0/78
|| src/exe/err.rs: 0/6
|| src/exe/map.rs: 48/50
|| src/exe/mod.rs: 75/127
|| src/proof.rs: 86/157
|| src/rpc.rs: 114/154
|| src/util.rs: 13/14
||
51.69% coverage, 366/708 lines covered

@sergey-melnychuk sergey-melnychuk merged commit 8dd10ba into main Oct 23, 2024
7 checks passed
@sergey-melnychuk sergey-melnychuk deleted the sm/docs branch October 23, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants