Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npsim: new version 1.2.0 #512

Merged
merged 1 commit into from
Aug 8, 2023
Merged

npsim: new version 1.2.0 #512

merged 1 commit into from
Aug 8, 2023

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Aug 8, 2023

Briefly, what does this PR introduce?

This new version introduces the specific detector thresholds as set in eic/npsim#9.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators @kkauder

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc added the backport releases/v0.20 Backport into releases/v0.20 label Aug 8, 2023
@wdconinc wdconinc merged commit b464cb0 into develop Aug 8, 2023
4 checks passed
@wdconinc wdconinc deleted the npsim-1.2.0 branch August 8, 2023 17:42
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Successfully created backport PR for releases/v0.20:

wdconinc added a commit that referenced this pull request Aug 8, 2023
# Description
Backport of #512 to `releases/v0.20`.

Co-authored-by: Wouter Deconinck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport releases/v0.20 Backport into releases/v0.20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant