Add support for exporting with Graphviz #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dont run graphviz if not installed * formatting
|
This looks great! I prefer the inlined version; the |
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for exporting the graph to SVG using Graphviz.
Check out the
./tests-viz/README.mdfor each of the examples rendered. I choose to keep these files in VCS so that we can use diffs to see changes to the viz algorithm easily and also to give new users an overview of the examples.This logic is pulled from egraphs-good/egglog#147 which is ported to the new format.
There is some discussion in that PR about ways to deal with primitives, whether they should be split into their own nodes or collapsed into calls, for ease of readability (egraphs-good/egglog#147 (comment)). This PR does not implement any of those transformations. I believe they can be implemented as follow-ups. I think they should all be able to be implemented asEGraph -> EGraphfunctions, which will allow us to keep the visualization logic unchanged.EDIT: I have also added a function to inline primitives into their parent nodes and show both options in the README.