Update symbol_table #456
Merged
Update symbol_table #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings symbol_table to the same version of hashbrown as egglog and has multi-threaded performance improvements.
CodSpeed Performance ReportMerging #456 will degrade performances by 12.76%Comparing Summary
Benchmarks breakdown
|
|
Huh. cykjson seems to be very sensitive to hashing. |
saulshanabrook
requested review from
saulshanabrook
and removed request for
mwillsey
saulshanabrook
approved these changes
Oct 29, 2024
|
We saw regression on cykjson, but we think it is fine because this is just a dependency change and seems unavoidable. Also for context we are also considering removing symbol_table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings symbol_table to the same version of hashbrown as egglog and has multi-threaded performance improvements. Follows up on PR#445 Update hashbrown.