New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HIGH_COST #433

Merged

Alex-Fischman merged 1 commit into egraphs-good:main from Alex-Fischman:high_cost

Oct 5, 2024

Contributor

Alex-Fischman commented Oct 4, 2024

This PR removes HIGH_COST for a few reasons:

It's unused.
It's buggy. On 32-bit systems (such as WASM?) i64::MAX will overflow.
It's undocumented, so I don't believe it's used outside of this crate. If it is used outside of this crate, I'll edit the PR to use isize instead of i64 to fix the bug, and add documentation.


          Remove HIGH_COST

3b646ef

Alex-Fischman requested a review from a team as a code owner

October 4, 2024 18:44

Alex-Fischman requested review from yihozhang and removed request for a team

October 4, 2024 18:44

yihozhang approved these changes

View reviewed changes

Collaborator

yihozhang left a comment

good catch!

Alex-Fischman merged commit 8ac9cae into egraphs-good:main

3 checks passed

Alex-Fischman deleted the high_cost branch

October 5, 2024 00:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet