Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vec-set #239

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add vec-set #239

merged 1 commit into from
Sep 29, 2023

Conversation

rtjoa
Copy link
Contributor

@rtjoa rtjoa commented Sep 28, 2023 •
edited
Loading

Add primitive (vec-set vec index val)

Testing

Added basic test to tests/vec.egg

@rtjoa rtjoa requested a review from a team as a code owner September 28, 2023 21:31
@rtjoa rtjoa requested review from ajpal and removed request for a team September 28, 2023 21:31
@rtjoa rtjoa mentioned this pull request Sep 28, 2023
Merged
oflatt
oflatt approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oflatt oflatt merged commit 43a6a3b into egraphs-good:main Sep 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oflatt oflatt oflatt approved these changes

@ajpal ajpal Awaiting requested review from ajpal ajpal is a code owner automatically assigned from egraphs-good/egglog-reviewers

@yihozhang yihozhang Awaiting requested review from yihozhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtjoa @oflatt