Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase iterations for function inlining to 3 once extraction uses less memory #494

Open
kirstenmg opened this issue Apr 26, 2024 · 0 comments
Assignees

Comments

@kirstenmg
Copy link
Collaborator

Currently, extraction uses a lot of memory. Function inlining makes extraction slower. Running cargo run -r tests/passing/small/fib_recursive.bril --run-mode compile-brilift --optimize-egglog true --optimize-brilift true --interp true on its own, for example, takes 7 seconds with 3 iterations of inlining. When run with all other tests (default 8 threads), too much memory is used and this test takes over a minute.

Function inlining is at 2 iterations currently so tests pass in a reasonable amount of time. Once extraction is less memory-intensive, function inlining should be bumped to 3 iterations (in config.rs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants