Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support nested filenames in bundle for different OS #393

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ideffix
Copy link

@ideffix ideffix commented Aug 18, 2021

In my project bundle sometimes contained nested path like somePath\index.css but normalizePath function is changing all back slashes to forward slashes. So if my bundle contains field somePath\index.css and normalizePath returned somePath/index.css I ended up with error:
[!] (plugin postcss) TypeError: Cannot read property 'modules' of undefined
This PR is fixing it by additionally checking bundle for non-normalizePath.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #393 (633dae1) into master (118253e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 633dae1 differs from pull request most recent head 23ad6ea. Consider uploading reports for the commit 23ad6ea to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   92.94%   92.98%   +0.04%     
==========================================
  Files          10       10              
  Lines         326      328       +2     
  Branches      115      117       +2     
==========================================
+ Hits          303      305       +2     
  Misses         22       22              
  Partials        1        1              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71593d9...23ad6ea. Read the comment docs.

@ideffix
Copy link
Author

ideffix commented Dec 2, 2021

@egoist any chance of having it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant