Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocotb scripts have outdated references? #497

Open
RTimothyEdwards opened this issue Sep 19, 2023 · 3 comments
Open

Cocotb scripts have outdated references? #497

RTimothyEdwards opened this issue Sep 19, 2023 · 3 comments

Comments

@RTimothyEdwards
Copy link
Contributor

There are parts of the cocotb scripts that appear to refer to the structure of caravel as it was some versions ago before the core was restructured. For example, in file cocotb/interfaces/caravel.py, the initialization routine defines:

self.hk_hdl      = dut.uut.housekeeping

But uut is the instance name of the top level module (caravel), and housekeeping is no longer a child of the top level, it is now a child of the SoC core. So this line can only be correct if written

self.hk_hdl    = dut.uut.chip_core.housekeeping

It is not clear to me how the cocotb testbenches even work with this error.

@marwaneltoukhy : Any ideas?

@shalan
Copy link
Contributor

shalan commented Sep 19, 2023

@M0stafaRady

@M0stafaRady
Copy link
Member

@RTimothyEdwards , Yes they are outdated. I was suppose to remove them from caravel since I moved the whole cocotb running scripts outside caravel into caravel-sim-infrastructure. All the needed documentation can be found inside the repo. You can find caravel tests here and here.

I added a PR to remove these old files

sorry for the the inconvenience.

@M0stafaRady
Copy link
Member

The location for adding the tests are under the user project repo not caravel repo. Until caravel and the soc is combined, I use the same flow that the user should use, to verify caravel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants