Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add edx_recommendations to generate_code_owner_mappings.py #402

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Aug 17, 2023

Fixes missing code_owner for:

  • "code_owner_module": "edx_recommendations.api.course_recommendations",
  • "name": "WebTransaction/Function/edx_recommendations.api.course_recommendations:LearnerDashboardRecommendationsView.get",

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robrap robrap merged commit 2ea6c52 into main Aug 18, 2023
4 checks passed
@robrap robrap deleted the robrap/update-codeowner-script branch August 18, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants