Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Celery protocol 2 #800

Open
timmc-edx opened this issue Sep 18, 2024 · 3 comments
Open

Upgrade to Celery protocol 2 #800

timmc-edx opened this issue Sep 18, 2024 · 3 comments

Comments

@timmc-edx
Copy link
Member

edx-platform, registrar, and enterprise-catalog are all using Celery task protocol 1. Upgrading to protocol 2 may remove some technical debt, and as a side benefit may help with #692.

Notes:

  • This can be identified by looking for APP.conf.task_protocol = 1 in an IDA's celery config file [edxapp example]
  • https://docs.celeryq.dev/en/stable/history/whatsnew-4.0.html doesn't mention anything about a stop-the-world aspect to the upgrade (just needing to get everything on 3.1.25 first) -- so this might be an easy rollout with no blue/green compatibility issues.
@robrap
Copy link
Contributor

robrap commented Sep 23, 2024

@timmc-edx: Are you also planning on opening a github issue against celery if you think they are missing test coverage, and potentially have a bug around this?

@timmc-edx
Copy link
Member Author

Unlikely. Too much of a rabbit hole to go down right now, unfortunately. (It's not even necessarily celery -- could be some other library that interacts with it.)

@robrap
Copy link
Contributor

robrap commented Sep 24, 2024

[inform] This work was scheduled because even though the issue will hopefully first have been fixed by DD in another way, this change will remove technical debt that would have avoided this situation altogether, and may help avoid future related situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready For Development
Development

No branches or pull requests

2 participants