From 617cf028a7f1b10d9405638c78280e81e7e53d9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= Date: Fri, 19 Apr 2024 00:16:44 +0100 Subject: [PATCH] wop --- ocaml/xapi/xapi_event.ml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ocaml/xapi/xapi_event.ml b/ocaml/xapi/xapi_event.ml index eb6843d15e5..2dcfb534a6d 100644 --- a/ocaml/xapi/xapi_event.ml +++ b/ocaml/xapi/xapi_event.ml @@ -720,6 +720,10 @@ let from ~__context ~classes ~token ~timeout = in let subs = List.map Subscription.of_string classes in let deadline = Unix.gettimeofday () +. timeout in + (* TODO: special case for task here? set before/after to 0 so we return quickly + also then overall rusage based throttler, perhaps very simple ewma filter with 0.75 new? + *) + (* We need to iterate because it's possible for an empty event set to be generated if we peek in-between a Modify and a Delete; we'll miss the Delete event and fail to generate the Modify because the