Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Let SocketIOConnection live in this repo #31

Closed
pnts-se opened this issue Sep 6, 2023 · 0 comments
Closed

[FEATURE REQUEST] Let SocketIOConnection live in this repo #31

pnts-se opened this issue Sep 6, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@pnts-se
Copy link
Contributor

pnts-se commented Sep 6, 2023

Is your feature request related to a problem? Please describe.
See edumeet/edumeet-common#11

Describe the solution you'd like
RoomServerConnection and SocketIOConnection is too many layers of abstraction. Let the socket be handled in RoomServerConnection. If nothing else, it'll generate easier to read debug logs.
@pnts-se pnts-se added the enhancement New feature or request label Sep 6, 2023
@havfo havfo closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@havfo @pnts-se