Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds module for dynamic ALLOWED_HOSTS #34

Open
wants to merge 8 commits into
base: develop-multisite
Choose a base branch
from

Conversation

rehan99000
Copy link

Description:
Adds module django-allowedsites for dynamic ALLOWED_HOSTS.

JIRA:
https://edlyio.atlassian.net/browse/EDLY-1493

Copy link

@zubair-arbi zubair-arbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra code.

@@ -109,3 +109,44 @@ def user_is_course_creator(request):

decoded_cookie_data = decode_edly_user_info_cookie(edly_user_info_cookie)
return decoded_cookie_data.get('is_course_creator', False)


class AllowedHosts(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this as we are using django-allowedsites app

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -37,6 +37,7 @@ def process_request(self, request):
setattr(settings, config_key, current_value)
else:
setattr(settings, config_key, config_value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this extra line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants