Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway-framework): add streamingfast blockmeta service client #597

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Feb 14, 2024

This PR adds the Streamingfast Blockmeta service client.

  • Added a copy of the service proto file.
  • Added proto-gen feature to run the build.rs based code generation. This is necessary because tonic-build requires protoc to be installed at build time. Running code generation in the CI makes no sense, so I opted for gating the code generation with a crate feature.
  • Added the SfBlockmetaClient gRPC client based on the generated files. Additionally, some integration tests covering the new client have been added.

Note: To enable the client integration tests, the IT_GATEWAY_FRAMEWORK_BLOCKMETA_URI and IT_GATEWAY_FRAMEWORK_BLOCKMETA_AUTH_TOKEN environment variables should be set, otherwise the tests are skipped.

@LNSD LNSD requested a review from Theodus February 14, 2024 16:41
@LNSD LNSD self-assigned this Feb 14, 2024
@LNSD LNSD marked this pull request as ready for review February 14, 2024 21:51
gateway-framework/Cargo.toml Outdated Show resolved Hide resolved
@LNSD LNSD added the DO NOT MERGE (delayed release) Delaying merge until next release cycle label Feb 14, 2024
@Theodus Theodus removed the DO NOT MERGE (delayed release) Delaying merge until next release cycle label Feb 16, 2024
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gateway-framework/tests/it_chains_ethereum_sf_blockmeta.rs Outdated Show resolved Hide resolved
gateway-framework/tests/it_chains_ethereum_sf_blockmeta.rs Outdated Show resolved Hide resolved
gateway-framework/src/chains/ethereum.rs Outdated Show resolved Hide resolved
gateway-framework/build.rs Outdated Show resolved Hide resolved
@LNSD LNSD merged commit d845b83 into main Feb 19, 2024
1 check passed
@LNSD LNSD deleted the lnsd/sf-blockmeta-client branch February 19, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants