Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PDB #45

Open
wants to merge 1 commit into
base: metadata-provider
Choose a base branch
from
Open

Conversation

fcurdi
Copy link

@fcurdi fcurdi commented Aug 5, 2020

PDB file is read just to determine local variables names. It is optional and even when present, not all variables have a name in the PDB file. So currently the result is a mix of real cil variable names and some generated ones for the non present names (local_$index). Besides this, cil allows multiple local variables with the same name. This change removes PDB reading to solve this last case, to unify variable names and so it is not necessary to provide the PDB file. Alternatively we can solve the name issue by assigning unique names to the ones that are duplicate. But i don't really see the point in reading the PDB optionally as it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant