Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional interface settings #132

Open
mehtank opened this issue Jan 2, 2021 · 3 comments · May be fixed by #158
Open

Additional interface settings #132

mehtank opened this issue Jan 2, 2021 · 3 comments · May be fixed by #158

Comments

@mehtank
Copy link
Contributor

mehtank commented Jan 2, 2021

I made a few configurable settings based on some UX feedback that I've gotten; see branch : https://github.com/mehtank/comingle/tree/settings

Currently I've added them as settings in Config.coffee, but it probably makes more sense to have them be selectable per meeting, perhaps via widgets on the landing page before clicking the "Create New Meeting" button, then stored in the meeting object? Or do you have thoughts on how to do that? I'm still slowly learning meteor and coffeescript, so making such deeper changes gets pretty slow for me.

  • hideWarnings : Silently ignore browser compatibility issues with jitsi
  • hideHeader : Don't show the main comingle link or the Meeting Title text box
  • hideOpenRooms : Don't create a separate section in the RoomList for backgrounded rooms that you're in so the room list stays the same as you move around
  • defaultSwitchRoom : Flip room selection interaction so that Shift-click opens the button menu and regular click automatically switches to the room
  • singleRoom : Don't do backgrounded rooms--leave old room as soon as you enter new room
  • preferCompact : Tighter cards in the room list (helps with Dealing with lots of rooms #20)

If they're false or not set, then the behavior should be exactly as it currently is.

@mehtank mehtank mentioned this issue Jan 3, 2021
@edemaine
Copy link
Owner

edemaine commented Jan 6, 2021

Some decisions/plans from today's meeting:

  • hideOpenRoom should probably always be on (open rooms should never be separated), but replaced by a toggle for separating starred rooms (Starring rooms #140)
  • singleRoom should always be on, once we remove background join (Starring rooms #140)
  • defaultSwitchRoom: propose renaming to quickJoin, and make a Settings toggle
  • Compact mode looks nice, and should be user Settings toggle; should probably also make default view a bit more compact (more medium). Maybe also incorporates hideHeader in some form...

@edemaine edemaine mentioned this issue Feb 23, 2021
6 tasks
@edemaine edemaine added admin Features for meeting admins only (formerly blocked) and removed admin Features for meeting admins only (formerly blocked) labels Feb 23, 2021
@mehtank
Copy link
Contributor Author

mehtank commented Mar 10, 2021

Created a new PR #158 to handle the various compact mode options as user toggleable settings (and configurable by default in Config.coffee). I may have gotten a bit carried away in terms of what you can hide, but you can now turn most everything off if you have a particularly small screen.

As an aside, the options in Config.coffee are at server-level, but it might make sense to have a corresponding set of settings at a meeting level? That is, some for meetings on a server, it may make sense to have the create room widget hidden by default, but other meetings it might want to start out visible.

@mehtank
Copy link
Contributor Author

mehtank commented Mar 10, 2021

Also added quickjoin to #158

@edemaine edemaine linked a pull request Mar 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants