Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling table of contents to this message #598

Open
6 of 8 tasks
edemaine opened this issue Mar 4, 2022 · 0 comments
Open
6 of 8 tasks

Scrolling table of contents to this message #598

edemaine opened this issue Mar 4, 2022 · 0 comments

Comments

@edemaine
Copy link
Owner

edemaine commented Mar 4, 2022 •
edited
Loading

  • Clicking on a message title should scroll the table of contents to that message. I think this makes sense in a symmetric fashion to clicking on TOC.
    • Avoid triggering when clicking link
    • Avoid triggering when selecting text?
    • Scroll smoothly unless prefers-reduced-motion
    • Ideally open up folded TOC parents to reveal child (like scrollToMessage) -- this would require a significant change to how TOC folding works
    • Trigger an animation on the specific TOC item, for when couldn't scroll to match up with message (near extremes)
  • *Hovering on a message title should highlight the corresponding TOC item, or if off-screen, a border at the top or bottom. (Replacing current red underline which is weird.)
  • Message title should also be draggable into table of contents.

Related: #552
edemaine added a commit that referenced this issue Mar 17, 2022
@edemaine
Clicking message scrolls TOC (#598)
4da1bc2
edemaine added a commit that referenced this issue Mar 18, 2022
@edemaine
Respect prefers-reduced-motion when scrolling TOC (#598)
d165348
edemaine added a commit that referenced this issue Mar 18, 2022
@edemaine
Respect prefers-reduced-motion when scrolling TOC (#598)
75e3b6f
edemaine added a commit that referenced this issue Mar 18, 2022
@edemaine
Pulse TOC item when clicking message header (#598)
fa4bed4
edemaine added a commit that referenced this issue Apr 11, 2022
@edemaine
Hovering over message highlights TOC item (#598)
d385b8c
edemaine added a commit that referenced this issue Apr 21, 2022
@edemaine
Improve message header clicking behavior (#598)
aad740a 
* Avoid calling `preventDefault` when a subitem gets clicked.
  This was breaking the Replace File button.
* Ignore clicks that were part of a text selection drag
edemaine added a commit that referenced this issue Apr 21, 2022
@edemaine
Improve message header clicking behavior (#598)
e9d20bc 
* Avoid calling `preventDefault` when a subitem gets clicked.
  This was breaking the Replace File button.
* Ignore clicks that were part of a text selection drag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edemaine