Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency json5 to 2.2.2 [security] - abandoned #225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 7, 2023

Mend Renovate

This PR contains the following updates:

Package Change
json5 2.1.3 -> 2.2.2

GitHub Vulnerability Alerts

CVE-2022-46175

The parse method of the JSON5 library before and including version 2.2.1 does not restrict parsing of keys named __proto__, allowing specially crafted strings to pollute the prototype of the resulting object.

This vulnerability pollutes the prototype of the object returned by JSON5.parse and not the global Object prototype, which is the commonly understood definition of Prototype Pollution. However, polluting the prototype of a single object can have significant security impact for an application if the object is later used in trusted operations.

Impact

This vulnerability could allow an attacker to set arbitrary and unexpected keys on the object returned from JSON5.parse. The actual impact will depend on how applications utilize the returned object and how they filter unwanted keys, but could include denial of service, cross-site scripting, elevation of privilege, and in extreme cases, remote code execution.

Mitigation

This vulnerability is patched in json5 v2.2.2 and later. A patch has also been backported for json5 v1 in versions v1.0.2 and later.

Details

Suppose a developer wants to allow users and admins to perform some risky operation, but they want to restrict what non-admins can do. To accomplish this, they accept a JSON blob from the user, parse it using JSON5.parse, confirm that the provided data does not set some sensitive keys, and then performs the risky operation using the validated data:

const JSON5 = require('json5');

const doSomethingDangerous = (props) => {
  if (props.isAdmin) {
    console.log('Doing dangerous thing as admin.');
  } else {
    console.log('Doing dangerous thing as user.');
  }
};

const secCheckKeysSet = (obj, searchKeys) => {
  let searchKeyFound = false;
  Object.keys(obj).forEach((key) => {
    if (searchKeys.indexOf(key) > -1) {
      searchKeyFound = true;
    }
  });
  return searchKeyFound;
};

const props = JSON5.parse('{\"foo\": \"bar\"}');
if (!secCheckKeysSet(props, ['isAdmin', 'isMod'])) {
  doSomethingDangerous(props); // \"Doing dangerous thing as user.\"
} else {
  throw new Error('Forbidden...');
}

If the user attempts to set the isAdmin key, their request will be rejected:

const props = JSON5.parse('{\"foo\": \"bar\", \"isAdmin\": true}');
if (!secCheckKeysSet(props, ['isAdmin', 'isMod'])) {
  doSomethingDangerous(props);
} else {
  throw new Error('Forbidden...'); // Error: Forbidden…
}

However, users can instead set the __proto__ key to {\"isAdmin\": true}. JSON5 will parse this key and will set the isAdmin key on the prototype of the returned object, allowing the user to bypass the security check and run their request as an admin:

const props = JSON5.parse('{\"foo\": \"bar\", \"__proto__\": {\"isAdmin\": true}}');
if (!secCheckKeysSet(props, ['isAdmin', 'isMod'])) {
  doSomethingDangerous(props); // \"Doing dangerous thing as admin.\"
} else {
  throw new Error('Forbidden...');
}

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

Images automagically compressed by Calibre's image-actions

Compression reduced images by 3.3%, saving 57.17 KB.

Filename Before After Improvement Visual comparison
template/public/img/uploads/banner_domi_mobile.webp 35.27 KB 34.83 KB -1.2% View diff
template/public/img/uploads/banner_hard1.webp 116.16 KB 113.99 KB -1.9% View diff
template/public/img/uploads/banner_hard2.webp 128.78 KB 127.34 KB -1.1% View diff
template/public/img/uploads/banner-quadrado.jpg 141.74 KB 132.46 KB -6.5% View diff
template/public/img/uploads/banner-quadrado.webp 82.03 KB 76.23 KB -7.1% View diff
template/public/img/uploads/banner-site.jpg 115.67 KB 108.22 KB -6.4% View diff
template/public/img/uploads/banner-site.webp 67.36 KB 60.91 KB -9.6% View diff
template/public/img/uploads/frete_gratis_full.webp 84.83 KB 83.56 KB -1.5% View diff
template/public/img/uploads/frete_gratis_mobile.webp 83.96 KB 82.66 KB -1.5% View diff
template/public/img/uploads/linha_dark-1.webp 54.54 KB 53.47 KB -2.0% View diff
template/public/img/uploads/linha_dark-2.webp 58.50 KB 57.41 KB -1.9% View diff
template/public/img/uploads/lov_banner_site-diadosnamorados.webp 80.50 KB 79.47 KB -1.3% View diff
template/public/img/uploads/lov_bannerssite-fireice-quadrado.webp 172.29 KB 164.79 KB -4.4% View diff
template/public/img/uploads/lov_bannerssite-fireice-retangular-site.webp 135.49 KB 133.33 KB -1.6% View diff
template/public/img/uploads/lov_post1-novosite1.webp 72.00 KB 70.84 KB -1.6% View diff
template/public/img/uploads/lov-banner-presentes-joias-site-.webp 68.42 KB 67.63 KB -1.2% View diff
template/public/img/uploads/lov-posts-presentes-joias-site.webp 63.15 KB 62.27 KB -1.4% View diff
template/public/img/uploads/selo_google.webp 1.61 KB 1.57 KB -2.4% View diff
template/public/img/uploads/vibre_1.webp 67.15 KB 65.25 KB -2.8% View diff
template/public/img/uploads/vibre_2.webp 78.40 KB 74.46 KB -5.0% View diff

55 images did not require optimisation.

@renovate
Copy link
Contributor Author

renovate bot commented Jan 7, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@renovate renovate bot changed the title chore(deps): update dependency json5 to 2.2.2 [security] chore(deps): update dependency json5 to 2.2.2 [security] - abandoned Jan 20, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Jan 20, 2023

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants