Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 12-hour mode (material theme), hour should read "12" instead of "00" #107

Open
jordanmhiller opened this issue Nov 30, 2018 · 3 comments

Comments

@jordanmhiller
Copy link

In English in 12-hour time, it's customary to show the hour as "12" instead of "00" with both AM and PM.
E.g.: https://simple.wikipedia.org/wiki/12-hour_clock

00:05 (24 hour) = 12:05AM (currently displays as 00:05AM)
12:05 (24 hour) = 12:05PM (currently displays as 00:05PM)

This is in the material theme.

On the classic theme, the drop-down doesn't have this issue (it shows 12:30PM), but once you select a time the display reverts to "00:30PM".

@mjperales
Copy link

I'm glad it's a known issue! I thought it was something I was doing wrong.

@mjperales
Copy link

If you're interested, I fixed the issue on my project by going to lib/common/TimePicker.js and updating line 566.

@ram4git
Copy link

ram4git commented Nov 4, 2019

@mjperales - do you have a PR or gist for the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants