Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Examples #25

Open
sdirix opened this issue Feb 5, 2018 · 0 comments
Open

Polish Examples #25

sdirix opened this issue Feb 5, 2018 · 0 comments

Comments

@sdirix
Copy link
Member

sdirix commented Feb 5, 2018

There are multiple small issues in the Examples:

  • Name of page and entry in navigation are mostly inconsistent
  • The max length of 5 does not make any sense in the array control example. It seems weird that the example contains initial invalid data
  • Categorization example is currently broken. It only renders No applicable renderer found.
  • Inferring a UI schema and Inferring both schemata are partially broken. For one of the elements they also render No applicable renderer found.
  • The star renderer in custom control example does not properly showcase how a good custom renderer should look like. A label (for example Rating) is missing. Also the cursor on the star renderer looks weird.

Also see eclipsesource/jsonforms#853 and eclipsesource/jsonforms#854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant