WIP: Add support for subtracting -header size from offset #7405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll remove the WIP tag after testing. For reference, here's the pre off-heap |
|
Personal build with these changes: 23147 |
|
I am able to reproduce the failure on my machine with 1 in 2 failure rate. We fail in compiled method: |
Update generateArrayElementAddressTrees to support subtracting -header size from element offset. IdiomRecognitionUtils::createIndexOffsetTree was subtracting -header size prior to off-heap changes. I am not sure if any opt looks for this pattern but adding the support to stay consistent with pre off-heap logic. Signed-off-by: Shubham Verma <[email protected]>
VermaSh
force-pushed
the
transformUtil_fixup
branch
from
7bb46f2
to
f31aaa2
Compare
|
Fixed previous build failures. Launched a new personal build with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update generateArrayElementAddressTrees to support subtracting -header size from element offset. IdiomRecognitionUtils::createIndexOffsetTree was subtracting -header size prior to off-heap changes. I am not sure if any opt looks for this pattern but adding the support to stay consistent with pre off-heap logic.