Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug[TW25783]: Fix Filter DateTime Column #585

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

vaibhavypatel
Copy link
Contributor

Change-Id: I88e37a6ff8a89fdbaf6a8062327e983e540450b8

@merks
Copy link
Contributor

merks commented Apr 4, 2024

Could you explain what is being fixed, how it looks before your change and how it looks after?

Previously org.eclipse.nebula.widgets.xviewer.XViewerSorter.parseDatePair(String, String) was called and it used either this:

 public final static SimpleDateFormat format10 = new SimpleDateFormat("MM/dd/yyyy");

or used java.text.SimpleDateFormat.SimpleDateFormat() which is locale specific.

Now that method is no longer called and you are using "MM/dd/yyyy hh:mm a" as the only hard coded format, which seems like your own personal choice rather that something that should be hard coded in the framework...

@vaibhavypatel
Copy link
Contributor Author

@merks
You are absolutely correct. I was not aware that other projects are making use of the XViewer. So, I fixed the code to satisfy the use-case I was trying to solve.

I resolved the issue by amending new commit. Please take a look. It is generic so that it does not require Date conversion now.
Filtering for the datetype column was not working properly. It will work after the change here gets merged.

Thank you :)

@dondunne
Copy link
Contributor

+1

@dondunne dondunne merged commit 3b7d1fa into eclipse:master Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants