From 60f2b68ad94363bb68a5ea377d7717c2004a5b30 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20L=C3=A4ubrich?= <laeubi@laeubi-soft.de>
Date: Fri, 22 Mar 2024 06:46:43 +0100
Subject: [PATCH] Cache the font of the slider / do not dispose colors

Currently the font and colors are created on each call of getTextFont /
get...Color and as these methods are called on each render it creates
many fonts/colors and their dispose listener.

This caches the font and removes the disposal of colors as SWT no longer
acquire native resources for colors. Beside that a new getFontSize
method is provided so one can easily override that.
---
 .../NebularSliderDefaultConfiguration.java    | 32 ++++++++++---------
 1 file changed, 17 insertions(+), 15 deletions(-)

diff --git a/widgets/nebulaslider/org.eclipse.nebula.widgets.nebulaslider/src/org/eclipse/nebula/widgets/opal/nebulaslider/NebularSliderDefaultConfiguration.java b/widgets/nebulaslider/org.eclipse.nebula.widgets.nebulaslider/src/org/eclipse/nebula/widgets/opal/nebulaslider/NebularSliderDefaultConfiguration.java
index c092212e3..2008818da 100644
--- a/widgets/nebulaslider/org.eclipse.nebula.widgets.nebulaslider/src/org/eclipse/nebula/widgets/opal/nebulaslider/NebularSliderDefaultConfiguration.java
+++ b/widgets/nebulaslider/org.eclipse.nebula.widgets.nebulaslider/src/org/eclipse/nebula/widgets/opal/nebulaslider/NebularSliderDefaultConfiguration.java
@@ -26,6 +26,7 @@ public class NebularSliderDefaultConfiguration implements NebulaSliderGraphicCon
 	private static final int BAR_HEIGHT = 12;
 	private static final int SELECTOR_HEIGHT = 32;
 	protected final NebulaSlider parentSlider;
+	private Font font;
 
 	public NebularSliderDefaultConfiguration(final NebulaSlider parentSlider) {
 		this.parentSlider = parentSlider;
@@ -68,14 +69,21 @@ public Color getArrowColor() {
 
 	@Override
 	public Font getTextFont() {
-		final FontData fontData = parentSlider.getFont().getFontData()[0];
-		final Font newFont = new Font(parentSlider.getDisplay(), fontData.getName(), Math.max(fontData.getHeight(), 14), SWT.BOLD);
-		parentSlider.addDisposeListener(e -> {
-			if (!newFont.isDisposed()) {
-				newFont.dispose();
-			}
-		});
-		return newFont;
+		if(font == null || font.isDisposed()) {
+			final FontData fontData = parentSlider.getFont().getFontData()[0];
+			Font newFont = new Font(parentSlider.getDisplay(), fontData.getName(), getFontSize(fontData), SWT.BOLD);
+			parentSlider.addDisposeListener(e -> {
+				if(!newFont.isDisposed()) {
+					newFont.dispose();
+				}
+			});
+			this.font = newFont;
+		}
+		return font;
+	}
+
+	protected int getFontSize(FontData fontData) {
+		return Math.max(fontData.getHeight(), 14);
 	}
 
 	@Override
@@ -99,13 +107,7 @@ public int getBarHeight() {
 	}
 
 	protected Color getAndDisposeColor(final int r, final int g, final int b) {
-		final Color color = new Color(parentSlider.getDisplay(), r, g, b);
-		parentSlider.addDisposeListener(e -> {
-			if (!color.isDisposed()) {
-				color.dispose();
-			}
-		});
-		return color;
+		return new Color(r, g, b);
 	}
 
 	@Override