Support xsi:type overrides when resolving content model #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@angelozerr would it be possible to get a review on this PR? Not really sure who to ask, or if this repository even accepts pull requests, but you seem to have merged one a month ago. |
angelozerr
reviewed
Oct 24, 2024
| @@ -22,6 +22,8 @@ | |||
| import java.util.logging.Level; | |||
| import java.util.logging.Logger; | |||
|
|
|||
| import com.google.common.collect.HashBasedTable; | |||
There was a problem hiding this comment.
Could we use a simple hashmap to avoid having depenedncy to commons google?
Sorry @Equinox- ! I have add a little comment. Let me more time to review your pr please. |
|
Thanks @Equinox- ! |
|
It looks like checks failed. I don't think it's related to my PR (seems like it's just flakey?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the content model to resolve
xsi:typebased polymorphism when navigating from a DOMElement to a CMXSDElement, fixing a bug where documentation and hints for the derived types were not presented.