Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow down of first context menu due to ELK loading services #1020

Open
Bananeweizen opened this issue Apr 9, 2024 · 0 comments
Open

Slow down of first context menu due to ELK loading services #1020

Bananeweizen opened this issue Apr 9, 2024 · 0 comments
Labels
bug Erroneous behaviour.
Milestone

Comments

@Bananeweizen
Copy link
Contributor

Describe the bug
Opening the first context menu in the package explorer/navigator of an application containing ELK leads to a notable delay before the menu becomes visible. ELK causes half a second of delay by loading layout services when it's property tester is used the first time:

grafik

Expected behavior
Bundle activators should do as little work as possible, as bundle activation can be triggered by UI interaction and will then slow down everything happening on the UI thread.

ELK Version
0.9.0

Additional context
Looking at the relevant method at

private void loadLayoutProvidersThroughJavaServices() {
it seems like all of that could be executed inside of LayoutMetadataService.getInstance() instead, which would defer the code until it's needed, and the plugin activation would be fast again.

@Bananeweizen Bananeweizen added the bug Erroneous behaviour. label Apr 9, 2024
@soerendomroes soerendomroes added this to the Release 0.9.2 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Erroneous behaviour.
Projects
None yet
Development

No branches or pull requests

2 participants