Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chown from onCreateCommand #97

Merged

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Sep 10, 2024

The chown command can be removed, because it no longer has any impact.
The devcontainer is always created as the user "vscode" as defined in .devcontainer.json and / or DOCKERFILE

Tested the following scenarios:

  • delete devcontainer (e.g. using colima delete) (before doing everything else)
  • recreate devcontainer
  • execute "velocitas init -fv"
  • add door.proto, add configuration to appmanifest.json and "re-generate gRPC files"
  • generate vehicle-model
  • start / stop runtime-local

Tested using the following branch:
https://github.com/SoftwareDefinedVehicle/vehicle-app-cpp-template/tree/remove_chown_test

Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BjoernAtBosch BjoernAtBosch merged commit cce3028 into eclipse-velocitas:main Sep 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants