Adopt new o.e.e.p2.publisher.eclipse API for IMacOsBundleUrlType #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After eclipse-tycho#4246, we can now consume the new org.eclipse.equinox.internal.p2.publisher.eclipse.IProductDescriptor.getMacOsBundleUrlTypes() API in the Tycho wrapper org.eclipse.tycho.p2.tools.publisher.ExpandedProduct. This is necessary to properly support link handler registrations in product's launchers. See eclipse-platform/eclipse.platform.ui#1901 eclipse-equinox/p2#533 for more information.
Test Results 600 files 600 suites 4h 23m 49s ⏱️ Results for commit 59c3d64. |
|
@laeubi: |
|
Just create a PR with required adjustment against Tycho 4.x branch. |
|
Should we merge or is anything left? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #4246, we can now consume the new
org.eclipse.equinox.internal.p2.publisher.eclipse.IProductDescriptor.getMacOsBundleUrlTypes()
API in the Tycho wrapper
org.eclipse.tycho.p2.tools.publisher.ExpandedProduct.
This is necessary to properly support link handler registrations in product's launchers.
See
eclipse-platform/eclipse.platform.ui#1901 eclipse-equinox/p2#533
for more information.