Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2331: Enhanced test case for resolving product deps #2587

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Issue 2331: Enhanced test case for resolving product deps #2587

merged 2 commits into from
Jul 16, 2023

Conversation

BenShelbourne
Copy link
Contributor

No description provided.

@BenShelbourne BenShelbourne mentioned this pull request Jun 26, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jun 26, 2023 •
edited
Loading

Test Results

   558 files  ±0     558 suites  ±0   4h 19m 57s ⏱️ - 25m 5s
   357 tests ±0     351 ✔️ ±0    6 💤 ±0  0 ❌ ±0 
1 071 runs  ±0  1 052 ✔️ ±0  19 💤 ±0  0 ❌ ±0 

Results for commit 352d1ce. ± Comparison against base commit 5b5d2b1.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member

laeubi commented Jun 26, 2023

@BenShelbourne thanks for enhancing the testcase, I'll try to look into this the next days.

@laeubi
Copy link
Member

laeubi commented Jun 28, 2023

@BenShelbourne can you check the ECA did you used the same mail address as the one you signed the ECA?

@laeubi
Copy link
Member

laeubi commented Jul 3, 2023

@BenShelbourne the testcase now passes on the Jenkins CI so I think it would be good to be merged but we need a valid ECA check before

@BenShelbourne
Copy link
Contributor Author

@laeubi sorry for the delay on this. I'm still awaiting approval from our legal team to check I am okay to sign it. There are people already with approval so I can't imagine it will be much longer until I get it! Thanks for the fix and sorry about the delay!!

@BenShelbourne
Copy link
Contributor Author

I've tested the latest changes and can confirm everything builds perfectly as expected so thank you for addressing this issue. I hopefully will sign the ECA soon and we can get this merged!

@BenShelbourne
Copy link
Contributor Author

I've now signed the ECA. Sorry about the delay!

@laeubi
Copy link
Member

laeubi commented Jul 8, 2023

@BenShelbourne mayn thanks the ECA works now but it seems there is a problem with the test now on macos/windows:

Caused by: org.apache.maven.plugin.MojoExecutionException: Detected Luna or older launcher feature org.eclipse.equinox.executable version 3.3.101.R34x_v20081125-7H-ELfE8hXnkE15Wh9Tnyu.
 Native product launchers for MacOSX can only be built against Eclipse Mars or newer.
To fix this, you can either build against Eclipse Mars or newer (recommended) or go back to Tycho <= 0.22.0
    at org.eclipse.tycho.plugins.p2.publisher.PublishProductMojo.checkMacOSLauncherCompatibility (PublishProductMojo.java:156)
    at org.eclipse.tycho.plugins.p2.publisher.PublishProductMojo.getExpandedLauncherBinaries (PublishProductMojo.java:121)
    at org.eclipse.tycho.plugins.p2.publisher.PublishProductMojo.publishContent (PublishProductMojo.java:102)
    at org.eclipse.tycho.plugins.p2.publisher.AbstractPublishMojo.execute (AbstractPublishMojo.java:39)

I think the easiest for this purpose would be to not include the native launcher in the build product.

@laeubi laeubi merged commit 493e17c into eclipse-tycho:master Jul 16, 2023
8 checks passed
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi left review comments

Assignees
No one assigned
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenShelbourne @laeubi