Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tycho-eclipserun still uses jdk17 #4193

Closed
Bananeweizen opened this issue Aug 30, 2024 · 7 comments
Closed

tycho-eclipserun still uses jdk17 #4193

Bananeweizen opened this issue Aug 30, 2024 · 7 comments

Comments

@Bananeweizen
Copy link
Contributor

Shouldn't we lift this to 21 with the recent platform requirements?
https://tycho.eclipseprojects.io/doc/latest/tycho-eclipse-plugin/eclipse-run-mojo.html#executionEnvironment

@laeubi
Copy link
Member

laeubi commented Aug 30, 2024

Tycho is still Java 17, what platform component specifically requires Java 21?

@Bananeweizen
Copy link
Contributor Author

I was trying to find some mailing list issue or similar now, but can't point to anything. Did I confuse that with "projects are allowed to require 21 independent of the platform" maybe?

@Bananeweizen Bananeweizen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
@Bananeweizen
Copy link
Contributor Author

Found it: https://www.eclipse.org/setups/sponsor/?scope=Eclipse%20IDE&campaign=2024-06 Starting with 2024-06 we need Java 21 to run the SDK, even though the platform still targets 17.
@laeubi I must admit I'm not sure what exactly that means for the tycho-eclipse mojo, you can probably judge that better.

@Bananeweizen Bananeweizen reopened this Aug 31, 2024
@laeubi
Copy link
Member

laeubi commented Aug 31, 2024

Basically that means that some Eclipse Plugins (e.g. m23, WWD, ..) require Java 21, and all SimRel Projects are in general allowed to use Java 21. But at the moment I'm not aware of any "core" bundle requiring it actually.

For Tycho the plan currently is to stay at Java 17 as long as possible, as soon as any "core" dependency requires a higher version we will upgrade Tycho 5.x to Java 21 (as it is a breaking change anyways).

For Tycho 4 we need to decide (might also depend on the time this happens and how far Tycho 5 line has evolved) if we just keep it at the current dependencies level, or we might make a Tycho 4.1.x line that requires higher Java version.

@Bananeweizen
Copy link
Contributor Author

It's not just about the bundles. The EPP packaging also requires 21:
grafik
As long as the runtime started by tycho-eclipse doesn't contain those, then it should be fine, agreed.

@merks
Copy link
Contributor

merks commented Aug 31, 2024

Yes EPP forces Java 21. The eclipse SDK is happy with 17. Very few bundles on the train actually require Java 21. So most likely most folks using tycho can run with 17 currently.

@Bananeweizen
Copy link
Contributor Author

Thanks for all the clarifications. I'll close the issue without changes then.

@Bananeweizen Bananeweizen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants