-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing version for build-helper-maven-plugin in generated pom #4174
Comments
This is the correct (maven) way.
Due to how maven work we only have two options:
Tycho currently uses option 1. |
The problem I see is that it's not really clear why the user has to configure the version. At least from my side, I saw this warning, looked through the project for all references of the "build-helper-maven-plugin" and ended up really confused, because the search returned nothing. Perhaps it would make sense for Tycho to create a dedicated log message in such a situation? Simply to give the user a clue what's causing this warning, rather than leaving them completely in the dark. |
The problem is that at that phase Tycho is mostly "blind" about the final maven pom model. |
By explicitly setting the version for the |
Within our build (using Tycho 4.0.8), I see several warnings of the form:
Which is weird, given that we don't use this plugin anywhere. But after looking through the files that are generated as part of our pomless build, I noticed the following entry that explains this weird behavior:
This execution is added by the TychoBundleMapping, so it seems the version qualifier is simply omitted? As a workaround, I've specified the version via a pluginManagement entry. But given that the generated poms are normally not visible, I assume that this isn't the proper solution?
tycho/tycho-extras/tycho-pomless/src/main/java/org/eclipse/tycho/pomless/TychoBundleMapping.java
Lines 157 to 176 in 5737192
The text was updated successfully, but these errors were encountered: