-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SharedHttpCacheStorage doesnt resolve redirect correctly if the uri that is given isn't normalized #2666
Comments
jcompagner
added a commit
to jcompagner/tycho
that referenced
this issue
Jul 28, 2023
that is given isn't normalized eclipse-tycho#2666 make sure taht the incoming uri param is normalized when used further up. This way it is not an extra redirect (so there are 2 redirects to the final source)
jcompagner
added a commit
to jcompagner/tycho
that referenced
this issue
Jul 28, 2023
that is given isn't normalized eclipse-tycho#2666 make sure taht the incoming uri param is normalized when used further up. This way it is not an extra redirect (so there are 2 redirects to the final source)
jcompagner
added a commit
to jcompagner/tycho
that referenced
this issue
Jul 28, 2023
that is given isn't normalized eclipse-tycho#2666 make sure taht the incoming uri param is normalized when used further up. This way it is not an extra redirect (so there are 2 redirects to the final source)
jcompagner
added a commit
to jcompagner/tycho
that referenced
this issue
Jul 28, 2023
that is given isn't normalized eclipse-tycho#2666 make sure taht the incoming uri param is normalized when used further up. This way it is not an extra redirect (so there are 2 redirects to the final source)
laeubi
pushed a commit
that referenced
this issue
Jul 28, 2023
…that is given isn't normalized #2666 make sure that the incoming uri param is normalized when used further up. This way it is not an extra redirect (so there are 2 redirects to the final source)
laeubi
pushed a commit
that referenced
this issue
Jul 29, 2023
…that is given isn't normalized #2666 (#2675) make sure that the incoming uri param is normalized when used further up. This way it is not an extra redirect (so there are 2 redirects to the final source) (cherry picked from commit f426ca2) Co-authored-by: Johan Compagner <[email protected]>
@jcompagner can this be closed now or do you still see issues? |
yes this one is fixed 4.0.1 works fine now for our product build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The getCacheEntry function:
https://github.com/eclipse-tycho/tycho/blob/master/p2-maven-plugin/src/main/java/org/eclipse/tycho/p2maven/transport/SharedHttpCacheStorage.java#L92
should normalize the incoming url, so that will not become an extra redirect that the HttpClient of java does (and then 2 redirects must be followed what the code of Tycho doesn't do and then you get a stack overflow because getCachedEntry is constantly called by itself through the redirect code.
that is the code that fixes it, the param is renamed and the an variable uri is made that is the normalized version of it.
Then the Java HttpClient doesn't treat this as a extra redirect.
The text was updated successfully, but these errors were encountered: