Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes SMC #765

Merged
merged 8 commits into from
Jul 15, 2024

Conversation

LuisRickert
Copy link
Contributor

Description

This PR sets the release Status of these models to 'Released'

All three of these Models have been 'MS3-approved' and merged based on this PR-506

With the Release of the three models above the previous model is deprecated. Its deprecation is mentioned in this Issue-670. Its release status never has been updated neither the status of the models.

With this PR we set the release status of the three secondary material to 'Release' and of the old model to 'deprecated'.

Closes #670

@@ -1,7 +1,7 @@
# Changelog
All notable changes to this model will be documented in this file.

## [Unreleased]
## [Deprecated]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think better would be to remove this 'Unreleased' tag to avoid any confusion. it is not important to keep it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, removed release status from all Release Notes. Release Status is only present in the metadata.json file

@@ -1 +1 @@
{ "status" : "release"}
{ "status" : "deprecated"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small correction required. this should be 'deprecate', without 'd'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@agg3fe agg3fe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agg3fe agg3fe merged commit 1160752 into eclipse-tractusx:main Jul 15, 2024
4 checks passed
@LuisRickert LuisRickert deleted the update_releaseNotes_smc branch October 1, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Model Deprecation]: io.catenax.secondary_material_content
2 participants