-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopfloor information types2 #257
Shopfloor information types2 #257
Conversation
samm:preferredName "Time Unit Enum"@en ; | ||
samm:description "Enumerates all time units"@en ; | ||
samm:dataType samm:curie ; | ||
samm-c:values ( "unit:secondUnitOfTime"^^samm:curie "unit:minuteUnitOfTime"^^samm:curie "unit:hour"^^samm:curie "unit:day"^^samm:curie "unit:week"^^samm:curie "unit:month"^^samm:curie "unit:year"^^samm:curie ) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the use of curies. this way it is correct. The curie type is from the SAMM meta model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Model LGTM
|
||
All notable changes to this model will be documented in this file. | ||
|
||
## [1.0.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to add the date of the MS3 approval to the RELEASE_NOTES once it is MS3 approved
Validation Report for io.catenax.shared.shopfloor_information_types/1.0.0/ShopfloorInformationTypes.ttlValidation failed: |
MS2 approval given with the condition that the model io.catenax.message_header:1.0.0 is released (otherwise model cannot validate) |
MS3 Criteria All required reviewers have approved this PR (see reviewers section) -> OK |
MS3: approval given with the condition that the model io.catenax.message_header:1.0.0 is released (otherwise model cannot validate) |
update message header prefix to shared namespace
Validation Report for io.catenax.shared.shopfloor_information_types/1.0.0/ShopfloorInformationTypes.ttlValidation failed: |
Validation Report for io.catenax.shared.shopfloor_information_types/1.0.0/ShopfloorInformationTypes.ttlValidation failed: |
Description
-->
Closes # #254
use of header of #227 required
Closes #
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)