diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2b6ab38e8..b06a8769b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,7 +8,7 @@ Closes # ## MS2 Criteria (to be filled out by PR reviewer) -- [ ] the model **validates** with the BAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar bamm-cli.jar -i \ -v ). The SAMM CLI is available [here](https://eclipse-esmf.github.io/esmf-developer-guide/tooling-guide/samm-cli.html) and in [GitHub](https://github.com/eclipse-esmf/esmf-sdk/releases/tag/v2.3.1) +- [ ] the model **validates** with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar samm-cli.jar aspect \ validate ). The SAMM CLI is available [here](https://eclipse-esmf.github.io/esmf-developer-guide/tooling-guide/samm-cli.html) and in [GitHub](https://github.com/eclipse-esmf/esmf-sdk/releases/tag/v2.3.1) - [ ] use **Camel-Case** (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case) - [ ] the identifiers for all model elements **start with a capital letter** except for properties - [ ] the identifier for **properties starts with a small letter** @@ -20,7 +20,7 @@ Closes # - [ ] fields `preferredName` and `description` are not the same - [ ] **`preferredName` should be human readable** and follow normal orthography (e.g., no camel case but normal word separation) - [ ] name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural. -- [ ] units are referenced from the BAMM unit catalog whenever possible +- [ ] units are referenced from the SAMM unit catalog whenever possible - [ ] **use constraints** to make known constraints from the use case explicit in the aspect model - [ ] when relying on **external standards**, they are referenced through a **"see"** element - [ ] all properties with an [simple type](https://eclipse-esmf.github.io/samm-specification/2.0.0/datatypes.html) have an example value