From 4c4f0ecd0fe50298853ab9338f1b6266fa630ac3 Mon Sep 17 00:00:00 2001
From: Phil Schneider <info@philschneider.de>
Date: Tue, 11 Jul 2023 20:15:30 +0200
Subject: [PATCH] chore: adjust roles for ssi endpoints (#125)

Adjusted the roles for the ssi endpoints
Rename response properties for the get endpoints of ssi

Refs: CPLP-2853
Reviewed-By: Norbert Truchsess <norbert.truchsess@t-online.de>
---
 .../Controllers/CompanyDataController.cs               | 10 +++++-----
 .../Models/UseCaseParticipationCreationData.cs         |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/administration/Administration.Service/Controllers/CompanyDataController.cs b/src/administration/Administration.Service/Controllers/CompanyDataController.cs
index 133845c093..5b01e74b66 100644
--- a/src/administration/Administration.Service/Controllers/CompanyDataController.cs
+++ b/src/administration/Administration.Service/Controllers/CompanyDataController.cs
@@ -196,7 +196,7 @@ public Task<IEnumerable<SsiCertificateData>> GetSsiCertificationData() =>
     /// <response code="204">Successfully created the use case particiation.</response>
     [HttpPost]
     [Consumes("multipart/form-data")]
-    [Authorize(Roles = "add_use_case_participation")]
+    [Authorize(Roles = "request_ssicredential")]
     [Authorize(Policy = PolicyTypes.ValidIdentity)]
     [Authorize(Policy = PolicyTypes.ValidCompany)]
     [Route("useCaseParticipation")]
@@ -217,7 +217,7 @@ public async Task<NoContentResult> CreateUseCaseParticipation([FromForm] UseCase
     /// <response code="204">Successfully created the ssi certificate.</response>
     [HttpPost]
     [Consumes("multipart/form-data")]
-    [Authorize(Roles = "add_ssi_certificate")]
+    [Authorize(Roles = "request_ssicredential")]
     [Authorize(Policy = PolicyTypes.ValidIdentity)]
     [Authorize(Policy = PolicyTypes.ValidCompany)]
     [Route("certificates")]
@@ -238,7 +238,7 @@ public async Task<NoContentResult> CreateSsiCertificate([FromForm] SsiCertificat
     /// <param name="sorting">Defines the sorting of the list</param>
     /// <response code="200">Collection of the credentials.</response>
     [HttpGet]
-    [Authorize(Roles = "admin_credential_decision")]
+    [Authorize(Roles = "decision_ssicredential")]
     [Authorize(Policy = PolicyTypes.ValidIdentity)]
     [Route("credentials", Name = nameof(GetCredentials))]
     [ProducesResponseType(typeof(IEnumerable<CredentialDetailData>), StatusCodes.Status200OK)]
@@ -258,7 +258,7 @@ public async Task<NoContentResult> CreateSsiCertificate([FromForm] SsiCertificat
     /// <returns>No Content</returns>
     /// <response code="204">Successfully approved the credentials.</response>
     [HttpPut]
-    [Authorize(Roles = "admin_credential_decision")]
+    [Authorize(Roles = "decision_ssicredential")]
     [Authorize(Policy = PolicyTypes.ValidIdentity)]
     [Route("credentials/{credentialId}/approval")]
     [ProducesResponseType(StatusCodes.Status204NoContent)]
@@ -276,7 +276,7 @@ public async Task<NoContentResult> ApproveCredential([FromRoute] Guid credential
     /// <returns>No Content</returns>
     /// <response code="204">Successfully rejected the credentials.</response>
     [HttpPut]
-    [Authorize(Roles = "admin_credential_decision")]
+    [Authorize(Roles = "decision_ssicredential")]
     [Authorize(Policy = PolicyTypes.ValidIdentity)]
     [Route("credentials/{credentialId}/reject")]
     [ProducesResponseType(StatusCodes.Status204NoContent)]
diff --git a/src/administration/Administration.Service/Models/UseCaseParticipationCreationData.cs b/src/administration/Administration.Service/Models/UseCaseParticipationCreationData.cs
index a40d32b047..382cc86e42 100644
--- a/src/administration/Administration.Service/Models/UseCaseParticipationCreationData.cs
+++ b/src/administration/Administration.Service/Models/UseCaseParticipationCreationData.cs
@@ -25,12 +25,12 @@ namespace Org.Eclipse.TractusX.Portal.Backend.Administration.Service.Models;
 public record UseCaseParticipationCreationData
 (
     Guid VerifiedCredentialExternalTypeDetailId,
-    VerifiedCredentialTypeId CredentialTypeId,
+    VerifiedCredentialTypeId CredentialType,
     IFormFile Document
 );
 
 public record SsiCertificateCreationData
 (
-    VerifiedCredentialTypeId CredentialTypeId,
+    VerifiedCredentialTypeId CredentialType,
     IFormFile Document
 );