Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ingress, improve dependencies check and add file header #147

Merged
merged 4 commits into from
May 22, 2024

Conversation

evegufy
Copy link
Contributor

@evegufy evegufy commented May 21, 2024

Description

Why

  • change ingress because I noticed that it isn't possible to enable it without TLS enabled as well: this is quite an annoyance if one wants to use the chart in a local testing setup due to this validation being place which is taking effect if the default values aren't commented out.
  • change dependencies check due to: QG checks (Release 24.05) #127 (comment)

Checklist

@evegufy evegufy marked this pull request as ready for review May 21, 2024 16:12
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, please add prerequisites to your chart again.

For helm check I just templated the chart with ingress.enabled = true and no error occurs (beside that the helm test workflow gonna test it).

Sidenote I missed previously, which I would not request as a point, but recommend: The system team provides an action for the changed dependency. You can refer to our workflow and increase the version of the dash tool here.

charts/policy-hub/README.md Outdated Show resolved Hide resolved
@evegufy evegufy force-pushed the chore/dependencies-check_ingress branch from e8e8f8c to d7fbb9b Compare May 22, 2024 06:14
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@evegufy
Copy link
Contributor Author

evegufy commented May 22, 2024

Overall LGTM, please add prerequisites to your chart again.

For helm check I just templated the chart with ingress.enabled = true and no error occurs (beside that the helm test workflow gonna test it).

Sidenote I missed previously, which I would not request as a point, but recommend: The system team provides an action for the changed dependency. You can refer to our workflow and increase the version of the dash tool here.

Good hint with the action from the systems team, I wasn't aware about that action, for now I'll leave the workflow as is because I have it running successfully in this manner a couple of other repos and I don't have time to rework it too much and don't want to spare such features like uploading the file if changed.

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart! LGTM. The honor of merging remains at your side :)

@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue May 22, 2024 that may be closed by this pull request
@evegufy evegufy merged commit 893ac15 into release/v1.0.0 May 22, 2024
11 checks passed
@evegufy evegufy deleted the chore/dependencies-check_ingress branch May 22, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRG 7.02: Missing license headers on a few files
2 participants