-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix ingress, improve dependencies check and add file header #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, please add prerequisites to your chart again.
For helm check I just templated the chart with ingress.enabled = true and no error occurs (beside that the helm test workflow gonna test it).
Sidenote I missed previously, which I would not request as a point, but recommend: The system team provides an action for the changed dependency. You can refer to our workflow and increase the version of the dash tool here.
move to downloading the tool at every run
e8e8f8c
to
d7fbb9b
Compare
Quality Gate passedIssues Measures |
Good hint with the action from the systems team, I wasn't aware about that action, for now I'll leave the workflow as is because I have it running successfully in this manner a couple of other repos and I don't have time to rework it too much and don't want to spare such features like uploading the file if changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart! LGTM. The honor of merging remains at your side :)
Description
Why
Checklist