-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: problems with busybox default shell on linux/amd64. #76
fix: problems with busybox default shell on linux/amd64. #76
Conversation
… entryscript to ash expressions.
@carslen, sorry there was a platform-dependent base image incompatibility (regarding the available shell syntax). We fixed that so that the chart test should go through now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check and update Copyright headers:
- New files shoud start with 2024 and not in the past as they did not exists back then
- update range of years in changed files (2022, 2023 → 2022, 2024)
- add an empty new line to the end of the files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check on the comments from Carsten Lenz regarding Copyright headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New Copyright regulations have been inserted
@carslen thanks for the heads up. copyright headers and newlines have been adapted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
WHAT
need to port entrypoint script to ash expressions as busybox alpine will not be bash compatible.
WHY
curently the chart test fails (without special configuraton or mount overrides).
FURTHER NOTES
Closes #75