Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: problems with busybox default shell on linux/amd64. #76

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Feb 5, 2024

WHAT

need to port entrypoint script to ash expressions as busybox alpine will not be bash compatible.

WHY

curently the chart test fails (without special configuraton or mount overrides).

FURTHER NOTES

Closes #75

@drcgjung drcgjung added the bug Something isn't working label Feb 5, 2024
@drcgjung
Copy link
Contributor Author

drcgjung commented Feb 5, 2024

@carslen, sorry there was a platform-dependent base image incompatibility (regarding the available shell syntax). We fixed that so that the chart test should go through now.

Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and update Copyright headers:

  • New files shoud start with 2024 and not in the past as they did not exists back then
  • update range of years in changed files (2022, 2023 → 2022, 2024)
  • add an empty new line to the end of the files

Copy link
Contributor

@Martin0815bla Martin0815bla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check on the comments from Carsten Lenz regarding Copyright headers.

Copy link
Contributor

@Martin0815bla Martin0815bla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Copyright regulations have been inserted

@drcgjung
Copy link
Contributor Author

drcgjung commented Feb 6, 2024

@carslen thanks for the heads up. copyright headers and newlines have been adapted.

@drcgjung drcgjung requested a review from carslen February 6, 2024 13:56
Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@carslen carslen merged commit 6ee2691 into eclipse-tractusx:main Feb 7, 2024
5 checks passed
@drcgjung drcgjung deleted the fix/75-provisioning-agent-chart-entrypoint branch April 17, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provisioning Agent Chart (main): chart test fails.
3 participants