Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/63 array merge #71

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

Martin0815bla
Copy link
Contributor

WHAT

Fix for bug #63 including UnitTest and related UnitTest files

WHY

Merging of two different Json files did not work properly

FURTHER NOTES

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Closes #63

Copy link
Contributor

@drcgjung drcgjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge logic seems valid.
Unit test is complete and useful, checked that it runs.

So LVGTM

@@ -24,6 +24,10 @@

<web-app xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd" version="2.4">
<display-name>RDF4J Server</display-name>
<!-- absolute ordering to prevent IllegalArgumentExcepition on startup -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That XML warning never occured to me. Seems to be an eclipse IDE issue. But does not harm

@drcgjung
Copy link
Contributor

@SebastianBezold It would be fantastic if you could review/merge this small one. I already checked and tested it.

@SebastianBezold SebastianBezold merged commit 8b54681 into eclipse-tractusx:main Jan 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
3 participants