fix(provisioning-agent): correct docker/pod user ids and version upgrade #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin0815bla
approved these changes
Oct 24, 2023
|
@carslen could you please have a look at this PR? |
2 tasks
|
has been merged into #52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Fixes the user ids used by the base image of the provisioning agent.
Introduces version upgrade script and upgrades version.
Pins (and upgrades) the github actions (and some kind/kubernetes-related versions) in the workflow.
Makes this repo a leading repo for all agent-related artifacts.
WHY
When mounting additional filesystems and/or using the builtin H2 database (for demo purposes on stable), the actual docker user (999:999) is incompatible to the pod security user/group/fs ids. The H2 database could not start/be connected.
KICS was complaining about unpinned github actions (vulnarable to supply chain attack)
Lot of dependabot hints to new github action versions
Tractus-X introduces new reference versions for kubernetes and kind.
Instead of having three different products in the Tractus-X dashboards and reports, all agent-related repos should be aggregated into a single product with this as the leading repo.
FURTHER NOTES