fix(workflows|docker): Lacking feature/binary in release image, extend workflows to be able to patch it. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ractusx repository affinity improved.
…ources into the docker environment.
drcgjung
requested review from
SebastianBezold
and removed request for
SebastianBezold
|
@carslen may I humbly propose that you have a look/adopt this PR, too ;-) Quite similar issue that with knowledge-agents-edc - A working maven-integrated docker build broke because we switched to github actions and a different release-branch approach. To fix the images, the build workflow would need to be manually triggered after the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Fixes docker build for release versions to include a callbackhandler feature/binary (which was tried to be copied with a SNAPSHOT in the jar name and which was lacking a META-INF manifest).
Adapts the workflows to be conformant to yamllint and allow for more options when doing a manual triggering.
WHY
#44
FURTHER NOTES
the merger could be so kind to manually trigger the build.yml workflow after the merge, such that the docker images are updated (maven packages are perfect).
Closes #44