Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support goal oriented skills #114

Merged

Conversation

drcgjung
Copy link
Contributor

WHAT

Flexibilizes the remoting agent engine when translating json responses.

WHY

When implementing "polymorphous" skills, it must be possible to return either complex structures or detailed properties thereof.

FURTHER NOTES

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Closes #73 <-- insert Issue number if one exists

@drcgjung drcgjung added the enhancement New feature or request label Apr 17, 2024
@drcgjung drcgjung marked this pull request as ready for review April 17, 2024 09:09
Copy link

@obalandi obalandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good

@drcgjung
Copy link
Contributor Author

@almadigabor there will be two final PRs (Upgrade EDC 0.6, Upgrade EDC 0.7) after this for 24.05

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor merged commit 33bc479 into eclipse-tractusx:main Apr 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Story: Define a Goal-Oriented Behaviour Prognosis Skill
3 participants