Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(binding-opcua): remove unnecessary data transformation #1119

Merged
merged 1 commit into from
Oct 13, 2023
Merged

refactor(binding-opcua): remove unnecessary data transformation #1119

merged 1 commit into from
Oct 13, 2023

Conversation

danielpeintner
Copy link
Member

see #1072

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@b44448b). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1119   +/-   ##
=========================================
  Coverage          ?   75.67%           
=========================================
  Files             ?       80           
  Lines             ?    16159           
  Branches          ?     1520           
=========================================
  Hits              ?    12229           
  Misses            ?     3888           
  Partials          ?       42
Files Coverage Δ
packages/binding-opcua/src/codec.ts 86.94% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

relu91
relu91 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in my understanding, it is just the first step of many right?

@danielpeintner danielpeintner mentioned this pull request Oct 13, 2023
Closed
@danielpeintner danielpeintner merged commit d6fdbdf into eclipse-thingweb:master Oct 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relu91 relu91 relu91 approved these changes

@JKRhb JKRhb JKRhb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielpeintner @relu91 @JKRhb