Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coap-server): add support for URI variables #1078

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Sep 11, 2023

Resolves #1015.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (c8177c2) 75.02% compared to head (2bc9e19) 75.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1078      +/-   ##
==========================================
+ Coverage   75.02%   75.06%   +0.03%     
==========================================
  Files          80       80              
  Lines       15610    15622      +12     
  Branches     1499     1498       -1     
==========================================
+ Hits        11712    11727      +15     
+ Misses       3862     3859       -3     
  Partials       36       36              
Files Changed Coverage Δ
packages/binding-coap/src/coap-server.ts 79.02% <100.00%> (+0.71%) ⬆️
packages/binding-http/src/http-server.ts 83.25% <100.00%> (-0.41%) ⬇️
packages/core/src/helpers.ts 83.00% <100.00%> (+0.74%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb
Copy link
Member Author

JKRhb commented Sep 11, 2023

Thank you for your approval, @egekorkan :) In the last two commits, I applied some additional refactoring/simplification, the functionality itself should remain unchanged, though.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JKRhb
Copy link
Member Author

JKRhb commented Sep 12, 2023

LGTM

Thank you! Is it okay for you to squash the fixup commits and then merge the PR? Or would you prefer the squash + merge approach (i.e., squashing all commits into one)?

@danielpeintner
Copy link
Member

I would "squash and merge" once we merge the PR.
I like this way best since it keeps the history of the PR till to the end and the final commit is clean when it gets merged into the master...

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!

@relu91 relu91 merged commit 692af10 into eclipse-thingweb:master Sep 12, 2023
9 checks passed
@JKRhb JKRhb deleted the coap-urivariables branch September 12, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URI Variables in CoAP are not supported
4 participants