Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid blocking codecov status checks #1060

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

danielpeintner
Copy link
Member

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1060 (c41e050) into master (0e6e117) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   75.38%   75.38%           
=======================================
  Files          80       80           
  Lines       15443    15443           
  Branches     1477     1477           
=======================================
  Hits        11641    11641           
  Misses       3766     3766           
  Partials       36       36           

@danielpeintner
Copy link
Member Author

danielpeintner commented Aug 11, 2023

Question: Mhh, how can we check whether it does what we asked for?

In this PR there was no real change to complain 🤷‍♂️
Anyhow, it shows ✔ for the 2 codecov checks.. maybe just try it out once we merge it..

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try, but the question is when are we going to switch back to normal behaviour? after release?

@relu91 relu91 merged commit 3a74512 into eclipse-thingweb:master Aug 11, 2023
8 checks passed
@JKRhb
Copy link
Member

JKRhb commented Aug 12, 2023

Let's try, but the question is when are we going to switch back to normal behaviour? after release?

That sounds good :) Maybe we also try to increase code coverage a bit once we are done with the strict ts configs, then I think codecov will give a good incentive to always add tests when a new feature is integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After integrating codecov we are getting failing CI builds
3 participants