Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict checking for package examples #1049

Merged

Conversation

danielpeintner
Copy link
Member

relates to #758

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #1049 (ca2de58) into master (7340a59) will decrease coverage by 0.24%.
Report is 13 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
- Coverage   75.78%   75.55%   -0.24%     
==========================================
  Files          80       80              
  Lines       15303    15342      +39     
  Branches     1444     1460      +16     
==========================================
- Hits        11597    11591       -6     
- Misses       3673     3717      +44     
- Partials       33       34       +1     
Files Changed Coverage Δ
packages/binding-http/src/routes/action.ts 57.42% <100.00%> (+2.88%) ⬆️
packages/core/src/exposed-thing.ts 66.91% <100.00%> (+0.14%) ⬆️
packages/core/src/helpers.ts 82.26% <100.00%> (+0.04%) ⬆️

... and 14 files with indirect coverage changes

@danielpeintner
Copy link
Member Author

I think the PR should be ready now...

@danielpeintner
Copy link
Member Author

I am not sure what we do with CI "codecov/project" failing. I guess we can ignore it for now.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thank you!! let's merge it.

@relu91 relu91 merged commit daa8453 into eclipse-thingweb:master Aug 11, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants